Require that external functions have explicit external call#3637
Open
henrikt-ma wants to merge 1 commit intomodelica:MCP/0031from
Open
Require that external functions have explicit external call#3637henrikt-ma wants to merge 1 commit intomodelica:MCP/0031from
henrikt-ma wants to merge 1 commit intomodelica:MCP/0031from
Conversation
Collaborator
|
I agree in principle, but it seems something's gone wrong with the PR since it includes hundreds of old commits. |
Collaborator
Author
Wrong base. Thanks for pointing it out! |
perost
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the problem that we didn't specify any difference in semantics of what this means in Base Modelica:
Clearly, the Modelica semantics makes no sense, since
'L.P.f'is not a valid identifier in C.The PR proposes to go with the first of the two possible solutions that come to mind: